Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick of #93107: Azure: use per-vmss vmssvm incremental cache #93469

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Cherry pick of #93107: Azure: use per-vmss vmssvm incremental cache #93469

merged 1 commit into from
Aug 7, 2020

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Jul 27, 2020

Cherry pick of #93107 on release-1.17.

#93107: Azure: use per-vmss vmssvm incremental cache

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Jul 27, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 27, 2020
@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Jul 27, 2020
@nilo19
Copy link
Member Author

nilo19 commented Jul 27, 2020

/retest

@feiskyer feiskyer changed the title Cherry pick of #93107: Azure: use per-vmss vmssvm incremental cacheAzure: per VMSS, incremental VMSS VMs cache Cherry pick of #93107: Azure: use per-vmss vmssvm incremental cache Jul 28, 2020
feiskyer
feiskyer reviewed Jul 28, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/priority important-soon
/kind bug
from parent PR

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Categorizes issue or PR as related to a bug. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 28, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2020
@feiskyer
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 1, 2020
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Aug 1, 2020
@bpineau @nilo19
Azure: per VMSS, incremental VMSS VMs cache
dbf7f9d 
Azure's cloud provider VMSS VMs API accesses are mediated through
a cache holding and refreshing all VMSS together.

Due to that we hit VMSSVM.List API more often than we could: an
instance's cache miss or expiration should only require a single
VMSS re-list, while it's currently O(n) relative to the number of
attached Scale Sets.

Under hard pressure (clusters with many attached VMSS that can't all
be listed in one sequence of successive API calls) the controller
manager might be stuck trying to re-list everything from scratch,
then aborting the whole operation; then re-trying and re-triggering
API rate-limits, affecting the whole Subscription.

This patch replaces the global VMSS VMs cache by per-VMSS VMs caches.
Refreshes (VMSS VMs lists) are scoped to the single relevant VMSS; under
severe throttling the various caches can be incrementally refreshed.

Signed-off-by: Benjamin Pineau <benjamin.pineau@datadoghq.com>
@nilo19 nilo19 force-pushed the bug/cherry-pick-93107-1.17 branch from 0b9aefe to dbf7f9d Compare August 3, 2020 02:22
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 3, 2020
feiskyer
feiskyer reviewed Aug 3, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2020
@feiskyer
Copy link
Member

feiskyer commented Aug 3, 2020

/sig cloud-provider

@nilo19
Copy link
Member Author

nilo19 commented Aug 3, 2020

/retest

2 similar comments
@nilo19
Copy link
Member Author

nilo19 commented Aug 4, 2020

/retest

@feiskyer
Copy link
Member

feiskyer commented Aug 5, 2020

/retest

@feiskyer
Copy link
Member

feiskyer commented Aug 6, 2020

/test pull-kubernetes-integration

@nilo19
Copy link
Member Author

nilo19 commented Aug 6, 2020

/retest

@nilo19
Copy link
Member Author

nilo19 commented Aug 6, 2020

/sig cloud-provider

@tpepper tpepper removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 6, 2020
@tpepper
Copy link
Member

tpepper commented Aug 6, 2020

Manually removed stuck "needs-sig" label.

@k8s-ci-robot k8s-ci-robot merged commit 950fc5e into kubernetes:release-1.17 Aug 7, 2020
@nilo19 nilo19 deleted the bug/cherry-pick-93107-1.17 branch August 7, 2020 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nilo19 @feiskyer @k8s-ci-robot @tpepper @bpineau